plugins/semgrep: add csmock semgrep plugin #149
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rhyw
force-pushed
the
semgrep
branch
2 times, most recently
from
5102f33
to
0ef1ef1
Compare
|
Any more updates needed please? |
|
@rhyw Did you look at the warnings produced by Differential PyLint? For example, this one looks valid: As far as I can see, no other csmock plug-in returns any value from |
py/plugins/semgrep.py
Outdated
| """ | ||
| import os | ||
|
|
||
| from csmock.common.util import sanitize_opts_arg |
Check warning
Code scanning / vcs-diff-lint
Unable to import 'csmock.common.util'
| parser.error("'--semgrep-rules-repo' is required to run semgrep scan") | ||
|
|
||
| # sanitize options passed to --semgrep-scan-opts to avoid shell injection | ||
| self.semgrep_scan_opts = sanitize_opts_arg(parser, args, "--semgrep-scan-opts") |
Check warning
Code scanning / vcs-diff-lint
Plugin.handle_args: Attribute 'semgrep_scan_opts' defined outside __init__
|
@lzaoral If we want to extend test coverage, I would focus on plug-ins with |
|
@rhyw Thanks! I have squashed my fixup commits, too. We do not want them in the |
Resolves: https://issues.redhat.com/browse/OSH-57
Closes: #149