Fix missing dependency #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyw
force-pushed
the
fix-missing-dependency
branch
from
bdaa1c3
to
443937e
Compare
kdudka
requested changes
Aug 24, 2023
There was a problem hiding this comment.
I can see that EPEL-7 builds in CI started to fail with:
error: line 53: Unknown tag: Recommends: modulemd-tools
... and there is no point in recommending modulemd-tools on RHEL-7/CentOS-7 anyway because there is no officially supported modulemd-tools package on such systems. Could you please make the recommendation conditional like this?
--- a/make-srpm.sh
+++ b/make-srpm.sh
@@ -125,13 +125,15 @@ Tool for plugging static analyzers into the build process, free of mock.
%package -n csmock-common
Summary: Core of csmock (a mock wrapper for Static Analysis tools)
Requires: csdiff > 3.0.3
Requires: csgcca
Requires: cswrap
Requires: mock
+%if 0%{?rhel} != 7
Recommends: modulemd-tools
+%endif
%description -n csmock-common
This package contains the csmock tool that allows to scan SRPMs by Static
Analysis tools in a fully automated way.
%package -n csmock-plugin-banditThe `bld2repo` executive is being used, but corresponding package `modulemd-tools` was not declared as a dependency earlier.
rhyw
force-pushed
the
fix-missing-dependency
branch
from
443937e
to
5924ce8
Compare
|
Updated as per suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bld2repoexecutive is being used, but corresponding packagemodulemd-toolswas not declared as a dependency earlier.