-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Settings Menu #552
Draft
ronjakrg
wants to merge
15
commits into
dev
Choose a base branch
from
550-settings-menu
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Adding Settings Menu #552
+611
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… moved some methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #550
This feature enables the user to access some settings in PROTzilla by the gear icon at the top right, yay! All settings can be loaded, viewed, changed and saved.
Changes
Added
settings
as a new Django appAdded and changed some HTMLs as well as methods in
views.py
to display the setting forms and plot previewAdded
general.yaml
andplots.yaml
to user_data/settings/ to store the user's settingsAdded
last_view
andrun_name
to most of the view functions to enable reloading the last view after saving or canceling the settingsMoved methods
parameter_from_post
andconvert_str_if_possible
from ui/runs/views_helper.py to protzilla/utilities/utilities.pyTesting
PR checklist
Development
Mergeability
black
Code review