Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Settings Menu #552

Draft
wants to merge 15 commits into
base: dev
Choose a base branch
from
Draft

Adding Settings Menu #552

wants to merge 15 commits into from

Conversation

ronjakrg
Copy link
Collaborator

@ronjakrg ronjakrg commented Nov 24, 2024

Description

fixes #550
This feature enables the user to access some settings in PROTzilla by the gear icon at the top right, yay! All settings can be loaded, viewed, changed and saved.

Changes

Added settings as a new Django app
Added and changed some HTMLs as well as methods in views.py to display the setting forms and plot preview
Added general.yaml and plots.yaml to user_data/settings/ to store the user's settings
Added last_view and run_name to most of the view functions to enable reloading the last view after saving or canceling the settings
Moved methods parameter_from_post and convert_str_if_possible from ui/runs/views_helper.py to protzilla/utilities/utilities.py

Testing

PR checklist

Development

  • If necessary, I have updated the documentation (README, docstrings, etc.)
  • If necessary, I have created / updated tests.

Mergeability

  • main-branch has been merged into local branch to resolve conflicts
  • The tests and linter have passed AFTER local merge
  • The code has been formatted with black

Code review

  • I have self-reviewed my code.
  • At least one other developer reviewed and approved the changes

@ronjakrg ronjakrg changed the title Adding Settings Page Adding Settings Menu Nov 24, 2024
Copy link

github-actions bot commented Nov 24, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  protzilla
  run.py
  run_helper.py
  protzilla/data_analysis
  differential_expression_helper.py 125, 143
  differential_expression_kruskal_wallis.py 227
  differential_expression_mann_whitney.py 266
  differential_expression_t_test.py
  plots.py
  protein_graphs.py
  ptm_analysis.py 56, 123-125
  protzilla/data_integration
  di_plots.py
  protzilla/data_preprocessing
  outlier_detection.py
  plots.py
  transformation.py
  protzilla/importing
  ms_data_import.py 122, 276
  protzilla/methods
  data_analysis.py 21, 174, 250, 283, 308, 351, 916, 935
  data_preprocessing.py
  importing.py 144
  protzilla/utilities
  transform_dfs.py
  utilities.py 142-152, 156-172
  ui/main
  settings.py 131
  ui/runs
  fields.py
  views.py 21, 41, 48, 72-73, 181, 258, 292, 458-459
  views_helper.py
  ui/runs/forms
  data_analysis.py 318-322, 379, 409, 445, 468, 1183, 1221, 1243
  ui/settings
  plot_template.py 13, 16, 20, 23, 51, 56, 58-69, 72-74
Project Total  

The report is truncated to 25 files out of 56. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

@ronjakrg ronjakrg self-assigned this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings menu
1 participant