Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving collapse after reload #543

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Saving collapse after reload #543

merged 5 commits into from
Nov 21, 2024

Conversation

sarahvgls
Copy link
Collaborator

@sarahvgls sarahvgls commented Nov 14, 2024

Description

In order to make the editing of steps easier and prevent automatic collapsing of all sections except for the active one, this PR is adding code that tracks the current state of the accordion to the local storage.
Also changed the remove icon and right-aligned it
This is a possible version of how this could be done, please give feedback if you have a different idea.

Changes

sidebar_section.html
runs.js

Testing

test by going trough different workflows and using the sidebar
local storage can be seen by entering inspection mode via "Application"

PR checklist

Development

  • If necessary, I have updated the documentation (README, docstrings, etc.)
  • If necessary, I have created / updated tests.

Mergeability

  • main-branch has been merged into local branch to resolve conflicts
  • The tests and linter have passed AFTER local merge
  • The code has been formatted with black

Code review

  • I have self-reviewed my code.
  • At least one other developer reviewed and approved the changes

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  protzilla
  run.py
  run_helper.py
  runner.py
  protzilla/data_analysis
  differential_expression.py
  differential_expression_helper.py 125, 143
  differential_expression_kruskal_wallis.py 227
  differential_expression_linear_model.py
  differential_expression_mann_whitney.py 266
  differential_expression_t_test.py
  protein_graphs.py
  ptm_analysis.py 56, 123-125
  protzilla/data_integration
  di_plots.py
  protzilla/data_preprocessing
  outlier_detection.py
  transformation.py
  protzilla/importing
  ms_data_import.py 122, 276
  protzilla/methods
  data_analysis.py 21, 174, 250, 283, 308, 351, 916, 935
  data_preprocessing.py
  importing.py 144
  protzilla/utilities
  transform_dfs.py
  utilities.py
  ui/main
  settings.py
  ui/runs
  fields.py
  views.py 23, 251, 285
  views_helper.py
  ui/runs/forms
  data_analysis.py 318-322, 379, 409, 445, 468, 1183, 1221, 1243
Project Total  

The report is truncated to 25 files out of 54. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

@sarahvgls sarahvgls marked this pull request as ready for review November 19, 2024 12:35
@sarahvgls sarahvgls requested a review from gitjannes November 19, 2024 12:36
Copy link
Collaborator

@gitjannes gitjannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eigentlich top, ich fänds noch gut, wenn der "Add Steps"-Button einen visuellen Indikator hätte, dass man ihn ein- und ausklappen kann, bzw auch in welchem State er sich befindet.

@sarahvgls sarahvgls changed the title WIP saving collapse after reload Saving collapse after reload Nov 19, 2024
@ronjakrg
Copy link
Collaborator

Ich finde die neuen Icons richtig gut! Wäre super, wenn wir die gleichen Icons auch für die neue UI beim Löschen von Runs verwenden könnten? :) @maximilianKalff

In der Benutzung ist mir persönlich gerade aufgefallen, dass man als User nicht unbedingt alleine auf die Idee kommen würde, die Sections selbst einzuklappen. Vielleicht wäre noch die Option, alle Sections (außer die aktive natürlich) automatisch einzuklappen praktisch? Da wir ja auch noch andere Features für die Sidebar (Visualisierung, welche Steps bereits berechnet wurden) planen, könnten wir vielleicht über 1-2 Steuerelemente über der ersten Section nachdenken ... Aber das nur als Idee, ich finde deine Änderung super! 👍

@sarahvgls sarahvgls marked this pull request as draft November 20, 2024 14:12
@sarahvgls sarahvgls marked this pull request as ready for review November 20, 2024 16:44
Copy link
Collaborator

@gitjannes gitjannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top, alles schick👍

@sarahvgls sarahvgls merged commit ea34db7 into dev Nov 21, 2024
1 check passed
@sarahvgls sarahvgls deleted the collapse-sections-in-sidebar branch November 21, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants