Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Calculate spinner #540

Merged
merged 8 commits into from
Nov 17, 2024
Merged

Fix Calculate spinner #540

merged 8 commits into from
Nov 17, 2024

Conversation

Jonas0000
Copy link
Collaborator

@Jonas0000 Jonas0000 commented Nov 13, 2024

Description

fixes #
spinner only if form validation passes - not after every click
trigger form validation
Button gets deactivated

PR checklist

Development

  • If necessary, I have updated the documentation (README, docstrings, etc.)
  • If necessary, I have created / updated tests.

Mergeability

  • main-branch has been merged into local branch to resolve conflicts
  • The tests and linter have passed AFTER local merge
  • The code has been formatted with black

Code review

  • I have self-reviewed my code.
  • At least one other developer reviewed and approved the changes

@Jonas0000 Jonas0000 requested a review from ronjakrg November 13, 2024 11:09
Copy link

github-actions bot commented Nov 13, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  protzilla
  run.py
  run_helper.py
  runner.py
  protzilla/data_analysis
  differential_expression.py
  differential_expression_helper.py 125, 143
  differential_expression_kruskal_wallis.py 227
  differential_expression_linear_model.py
  differential_expression_mann_whitney.py 266
  differential_expression_t_test.py
  protein_graphs.py
  ptm_analysis.py 56, 123-125
  protzilla/data_integration
  di_plots.py
  protzilla/data_preprocessing
  outlier_detection.py
  transformation.py
  protzilla/importing
  ms_data_import.py 122, 276
  protzilla/methods
  data_analysis.py 21, 174, 250, 283, 308, 351, 916, 935
  data_preprocessing.py
  importing.py 144
  protzilla/utilities
  transform_dfs.py
  utilities.py
  ui/main
  settings.py
  ui/runs
  fields.py
  views.py 23, 251, 285
  views_helper.py
  ui/runs/forms
  data_analysis.py 318-322, 379, 409, 445, 468, 1183, 1221, 1243
Project Total  

The report is truncated to 25 files out of 54. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

Copy link
Collaborator

@sarahvgls sarahvgls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finde ich gut, danke!!
Frage mich gerade, ob es konsistent wäre, dem Plot button auch so ein loading feedback zu geben?

Copy link
Collaborator

@ronjakrg ronjakrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke dir für die Anpassung! Die Bugs, die ich angemerkt hatte, sind jetzt gefixt! :)

@Jonas0000
Copy link
Collaborator Author

Finde ich gut, danke!! Frage mich gerade, ob es konsistent wäre, dem Plot button auch so ein loading feedback zu geben?

Das ist eine gute Idee! Ich würde das aber erst einmal so pushen, damit das derzeitige Problem behoben ist. Den Spinner noch auf weitere Buttons können wir dann später noch ergänzen :)

@Jonas0000 Jonas0000 merged commit 46bd04d into dev Nov 17, 2024
1 check passed
@Jonas0000 Jonas0000 deleted the CalculateSpinner branch December 17, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants