Footer calculate back next #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitjannes
reviewed
Nov 12, 2024
ui/runs/static/runs/runs.js
Outdated
| @@ -32,4 +32,12 @@ $(document).ready(function () { | |||
| let id = $(this).attr("id"); | |||
| $('#chosen-' + id).text(this.files[0].name); | |||
| }); | |||
|
|
|||
| // control calculate buttons in header | |||
There was a problem hiding this comment.
Suggested change
| // control calculate buttons in header | |
| // control calculate buttons in footer |
gitjannes
reviewed
Nov 12, 2024
ui/runs/static/runs/runs.js
Outdated
Comment on lines
37
to
41
| $('#calculate_parameters_submit_plot_form').click(function() { | ||
| $("#calc_form").submit(); | ||
| }); | ||
| $('#calculate_parameters_submit_form').click(function() { | ||
| $("#calc_from_method").submit(); |
There was a problem hiding this comment.
Einheitliche Benennung von den from ids wäre schön
There was a problem hiding this comment.
Danke, ich habe die Namensgebung geupdatet :)
gitjannes
requested changes
Nov 12, 2024
ronjakrg
reviewed
Nov 12, 2024
ui/runs/templates/runs/details.html
Outdated
| </div> | ||
| </div> | ||
|
|
||
| <div class="footer border border-end-0 border-start-0 border-bottom-0"> |
There was a problem hiding this comment.
Instead of excluding the three borders, you can use border-top as well to just include the one you want :) And I'd maybe add pt-3 so that you have the same paddings as with the borders in the navbar
But besides that, I personally like the alignment of these two buttons a lot!
There was a problem hiding this comment.
Thx and good optimisations, I have implemented them :)
ronjakrg
approved these changes
Nov 12, 2024
gitjannes
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added footer to the run-details-page with Calculate/Next/Back.buttons and fixed scrolling.
Changes
run-related files (
details.html, styles.css, runs.js)Testing
PR checklist
Development
Mergeability
blackCode review