Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint for export workflow #538

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Add hint for export workflow #538

merged 4 commits into from
Nov 13, 2024

Conversation

ronjakrg
Copy link
Collaborator

@ronjakrg ronjakrg commented Nov 11, 2024

Description

Changed the url of GitHub logo
Added message after a workflow has been exported
Added button to go back from managing databases

Changes

navbar.html has new url
views.py now imports new modules and has a message which indicates a successful export and shows the destination path
databases.html has new button

Testing

PR checklist

Development

  • If necessary, I have updated the documentation (README, docstrings, etc.)
  • If necessary, I have created / updated tests.

Mergeability

  • main-branch has been merged into local branch to resolve conflicts
  • The tests and linter have passed AFTER local merge
  • The code has been formatted with black

Code review

  • I have self-reviewed my code.
  • At least one other developer reviewed and approved the changes

@ronjakrg ronjakrg changed the title Added hint for export workflow Add hint for export workflow Nov 11, 2024
Copy link

github-actions bot commented Nov 11, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  protzilla
  run.py
  run_helper.py
  runner.py
  protzilla/data_analysis
  differential_expression.py
  differential_expression_helper.py 125, 143
  differential_expression_kruskal_wallis.py 227
  differential_expression_linear_model.py
  differential_expression_mann_whitney.py 266
  differential_expression_t_test.py
  protein_graphs.py
  ptm_analysis.py 56, 123-125
  protzilla/data_integration
  di_plots.py
  protzilla/data_preprocessing
  outlier_detection.py
  transformation.py
  protzilla/importing
  ms_data_import.py 122, 276
  protzilla/methods
  data_analysis.py 21, 174, 250, 283, 308, 351, 916, 935
  data_preprocessing.py
  importing.py 144
  protzilla/utilities
  transform_dfs.py
  utilities.py
  ui/main
  settings.py
  ui/runs
  fields.py
  views.py 1, 21, 391
  views_helper.py
  ui/runs/forms
  data_analysis.py 318-322, 379, 409, 445, 468, 1183, 1221, 1243
Project Total  

The report is truncated to 25 files out of 54. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

@ronjakrg ronjakrg marked this pull request as ready for review November 12, 2024 11:19
@@ -35,6 +35,12 @@
{% endfor %}
</div>
{% endif %}

<div class="mb-4">
<button id="back-button" type="button" class="btn btn-red mr-auto" onclick="window.location.href='http://127.0.0.1:8000/';">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

statt onclick sollte auch nur href="/" genügen, dass wäre dann auch mit line 4 in navbar.html konsistent sein.

Suggested change
<button id="back-button" type="button" class="btn btn-red mr-auto" onclick="window.location.href='http://127.0.0.1:8000/';">
<button id="back-button" type="button" class="btn btn-red mr-auto" href="/">

Copy link
Collaborator Author

@ronjakrg ronjakrg Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Habe gerade mal nachgeschaut das href="/" scheint nur mit dem <a>-Tag zu gehen und wurde so auch z. B. in details.html verwendet. Passe das entsprechend an, danke!

Copy link
Collaborator

@gitjannes gitjannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht gut aus 👍
Wegen dem requested change in databases.html, ich persönlich finde die kurze Variante cleaner, ich kann mir auch vorstellen, dass die statische lokale Adresse Probleme bereiten könnte, sollte Protzilla nicht dort laufen.

@ronjakrg ronjakrg requested a review from gitjannes November 12, 2024 15:36
Copy link
Collaborator

@gitjannes gitjannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top, passt meiner Meinung nach 👍. Wäre natürlich cool, wenn dann ein ähnlicher Footer wie der von Lennard für die databases.html verwendet wird, aber da muss er ja auch erstmal fertig sein.

Copy link
Collaborator

@noLeonardo noLeonardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schöner Code und funktioniert auch alles :)
Beim Back-Button könnten wir die Positionierung vielleicht nochmal diskutieren, wenn wir ein einheitliches Design-Konzept haben. Ich persönlich finde es direkt am linken Rand und/ oder unten ein bisschen intuitiver, aber von der Funktionsweise top.

@ronjakrg ronjakrg merged commit 89e36cb into dev Nov 13, 2024
1 check passed
@ronjakrg ronjakrg deleted the hint-export-workflow branch November 13, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants