Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate spinner and hide next button #536

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Calculate spinner and hide next button #536

merged 3 commits into from
Nov 9, 2024

Conversation

Jonas0000
Copy link
Collaborator

@Jonas0000 Jonas0000 commented Nov 7, 2024

Description

The calculate button shows a loading spinner while calculating. The next button at the last step is now hidden.

Changes

ui/runs/static/runs/runs.js
ui/runs/templates/runs/details.html

Testing

A walkthrough with steps of a sample workflow.

PR checklist

Development

  • If necessary, I have updated the documentation (README, docstrings, etc.)
  • If necessary, I have created / updated tests.

Mergeability

  • main-branch has been merged into local branch to resolve conflicts
  • The tests and linter have passed AFTER local merge
  • The code has been formatted with black

Code review

  • I have self-reviewed my code.
  • At least one other developer reviewed and approved the changes

@Jonas0000 Jonas0000 requested a review from sarahvgls November 7, 2024 12:00
Copy link

github-actions bot commented Nov 7, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  protzilla
  run.py
  run_helper.py
  runner.py
  protzilla/data_analysis
  differential_expression_anova.py
  differential_expression_linear_model.py
  differential_expression_mann_whitney.py 263
  differential_expression_t_test.py
  protein_graphs.py
  ptm_analysis.py 115-116, 134-136
  protzilla/data_integration
  di_plots.py
  enrichment_analysis_gsea.py
  protzilla/data_preprocessing
  filter_proteins.py
  outlier_detection.py
  peptide_filter.py
  transformation.py
  protzilla/importing
  ms_data_import.py 122, 276
  protzilla/methods
  data_analysis.py
  data_preprocessing.py
  importing.py 142
  protzilla/utilities
  transform_dfs.py
  utilities.py
  ui/main
  settings.py
  ui/runs
  fields.py
  views.py
  views_helper.py
Project Total  

The report is truncated to 25 files out of 51. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

Copy link
Collaborator

@noLeonardo noLeonardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button looks good and the code as well. Everything works :)

Copy link
Collaborator

@maximilianKalff maximilianKalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spinning button looks amazing and works as expected. The code is understandable and well written :))

Copy link
Collaborator

@sarahvgls sarahvgls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find ich sonst richtig gut und passt schön in den bisherigen Code rein :)

class="btn btn-red">
<button type="submit" id="calculate_parameters_submit"
class="btn btn-red calculateSpinner">
Calculate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ein kleine Frage: Ist Calculate hier einfach der Value des Buttons bevor er gedrückt wird und nur eine andere Schreibweise als vorher?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, genau. Calculate ist hier nur der Text, der auf dem Button angezeigt wird.
Wenn man zusätzlich noch name und value angeben würde, würden die Werte als name=value mit dem Form übermittelt werden. Vorher beim Input war der Unterscheid, dass ein Input kein Start und End-Tag hat, sondern nur aus einem Tag besteht, sodass hier der Text nicht zwischen die Tags geschrieben werden kann. Bei diesem Wird dann value als Anzeigetext verwendet.
Wenn dich das noch genauer interessiert, ist diese Website ganz gut zum herumspielen: https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_input_test

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay danke! Das schaue ich mir mal an, habe damit bisher noch nicht so viel Kontakt gehabt!

@sarahvgls
Copy link
Collaborator

Am besten dann mit Squash und merge auf dev tun, dann ist es dort etwas ordentlicher :)

@Jonas0000 Jonas0000 merged commit 50ac801 into dev Nov 9, 2024
1 check passed
@Jonas0000 Jonas0000 deleted the CalculateSpinner branch November 10, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants