Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click-navigation to future steps #515

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

henninggaertner
Copy link
Collaborator

@henninggaertner henninggaertner commented Jun 21, 2024

Description

fixes #511

Changes

Just add a check when trying to go forward to see if that step has output. Because we automatically delete all the outputs of future steps on calculation, we should never have the issue that a previous step does not have output after going to a future step with output.

Testing

Do a run, calculate some steps, go back and then go forwards again.

PR checklist

Development

  • If necessary, I have updated the documentation (README, docstrings, etc.)
  • If necessary, I have created / updated tests.

Mergeability

  • main-branch has been merged into local branch to resolve conflicts
  • The tests and linter have passed AFTER local merge
  • The code has been formatted with black

Code review

  • I have self-reviewed my code.
  • At least one other developer reviewed and approved the changes

@henninggaertner henninggaertner changed the title Add hidden workflows for test Click-navigation to future steps Jun 25, 2024
@henninggaertner henninggaertner linked an issue Jun 25, 2024 that may be closed by this pull request
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  protzilla
  run.py
  run_helper.py
  runner.py
  steps.py 630, 641
  protzilla/data_analysis
  differential_expression_anova.py
  differential_expression_linear_model.py
  differential_expression_t_test.py
  protein_graphs.py
  ptm_analysis.py 115-116, 134-136
  protzilla/data_integration
  di_plots.py
  enrichment_analysis_gsea.py
  protzilla/data_preprocessing
  outlier_detection.py
  transformation.py
  protzilla/importing
  ms_data_import.py 122, 276
  peptide_import.py
  protzilla/methods
  data_analysis.py 635-641, 703
  data_preprocessing.py
  importing.py 142
  protzilla/utilities
  transform_dfs.py
  utilities.py
  ui/main
  settings.py
  ui/runs
  fields.py
  views.py
  views_helper.py
  ui/runs/forms
  data_analysis.py 927-935, 976-980, 996, 1002
Project Total  

The report is truncated to 25 files out of 74. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

@henninggaertner henninggaertner mentioned this pull request Dec 18, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Cannot go to a future step
1 participant