Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching for python dependencies in ci.yml #346

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

henninggaertner
Copy link
Collaborator

@henninggaertner henninggaertner commented Dec 14, 2023

  • fixes (in part) the runtime of the ci on github, saving some 15 odd seconds of installing libraries using pip

  • this particular change adds a step called "cache python dependencies", which on the first run (as seen here) doesn't find the cached dependencies, but on a re-run uses the previously downloaded deps

  • the cache is updated, whenever the (hash of) requirements.txt changes, which is quite rare.

PR checklist

  • main-branch has been merged into local branch to resolve conflicts
  • tests and linter have passed AFTER local merge
  • at least one other dev reviewed and approved
  • documentation
  • tests

Copy link

Coverage report

The coverage rate went from 70.21% to 69.55% ⬇️
The branch rate is 63%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@henninggaertner henninggaertner added the enhancement New feature or request label Dec 14, 2023
Copy link
Collaborator

@antonneubauer antonneubauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The benefits seem pretty small but maybe that'll change with future dependencies

@henninggaertner henninggaertner merged commit d3528bf into main Dec 14, 2023
1 check passed
@henninggaertner henninggaertner deleted the github-ci-caching branch December 20, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants