Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

317 add axis labels #343

Merged
merged 5 commits into from
Dec 12, 2023
Merged

317 add axis labels #343

merged 5 commits into from
Dec 12, 2023

Conversation

gritlm
Copy link
Collaborator

@gritlm gritlm commented Dec 12, 2023

Description (what might a Reviewer want to know)

  • everytime a plot is created (eg create_boxplot is called) the axis titles are set
  • look at the diagrams and check if the correct title is given

PR checklist

  • main-branch has been merged into local branch to resolve conflicts
  • tests and linter have passed AFTER local merge
  • at least one other dev reviewed and approved
  • documentation
  • tests

@gritlm gritlm requested a review from selenabr December 12, 2023 09:41
@gritlm gritlm linked an issue Dec 12, 2023 that may be closed by this pull request
3 tasks
Copy link

github-actions bot commented Dec 12, 2023

Coverage report

The coverage rate went from 70.01% to 70.01% ⬆️
The branch rate is 63%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

protzilla/data_preprocessing/filter_proteins.py

100% of new lines are covered (77.27% of the complete file).

protzilla/data_preprocessing/filter_samples.py

100% of new lines are covered (100% of the complete file).

protzilla/data_preprocessing/imputation.py

100% of new lines are covered (97.08% of the complete file).

protzilla/data_preprocessing/normalisation.py

100% of new lines are covered (97.5% of the complete file).

protzilla/data_preprocessing/plots.py

100% of new lines are covered (87.6% of the complete file).

protzilla/data_preprocessing/transformation.py

100% of new lines are covered (82.75% of the complete file).

@gritlm gritlm merged commit 27ad644 into main Dec 12, 2023
1 check passed
@henninggaertner henninggaertner deleted the 317-add-axis-labels branch December 20, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add axis labels
2 participants