Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

312 312 fixing selection in each step after calculating is resetting #334

Conversation

gritlm
Copy link
Collaborator

@gritlm gritlm commented Nov 29, 2023

Description (what might a Reviewer want to know)
-Problem: When the user selects plot parameters and calculates, the plot parameters are reset to the default values without being used.
-Solution: The disable the field when the shouldn't be used (e.g. plot sth that isn't yet calculated)
-We added a fieldset in details.html in order to create a container which can be disabled. Then we added disable_plot_fields() to disable these fields and called it.
-Tests: simply go to a step where you can calculate and plot (and are able to specify plot parameters).

PR checklist

  • main-branch has been merged into local branch to resolve conflicts
  • tests and linter have passed AFTER local merge
  • at least one other dev reviewed and approved
  • (documentation)
  • (tests)

Copy link

Coverage report

The coverage rate went from 70.09% to 70.09% ➡️
The branch rate is 63%.

50% of new lines are covered.

Diff Coverage details (click to unfold)

protzilla/data_preprocessing/plots_helper.py

50% of new lines are covered (13.04% of the complete file).
Missing lines: 31

@henninggaertner
Copy link
Collaborator

After calculating and plotting, a mere change in the parameters for the current functionality will remove the ability to change the plot of the previously calculated data. Is this intended?

@henninggaertner
Copy link
Collaborator

Works nicely. The configuration where after plotting something, then chaning a parameter (but not calculating!) you are then unable to select anything from the plotting fields is logical, as it could be misleading when there are different parameters on the screen but the plot is from "old" data.

Copy link
Collaborator

@henninggaertner henninggaertner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@JanniRoebbecke JanniRoebbecke merged commit 19c6d24 into main Nov 30, 2023
1 check passed
@henninggaertner henninggaertner deleted the 312-312-fixing-selection-in-each-step-after-calculating-is-resetting branch December 20, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

312-fixing-selection-in-each-step-after-calculating-is-resetting
3 participants