-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
312 312 fixing selection in each step after calculating is resetting #334
312 312 fixing selection in each step after calculating is resetting #334
Conversation
…-is-resetting' of https://github.com/cschlaffner/PROTzilla2 into 312-312-fixing-selection-in-each-step-after-calculating-is-resetting
Co-authored-by: JanniRoebbeke <[email protected]>
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)protzilla/data_preprocessing/plots_helper.py
|
After calculating and plotting, a mere change in the parameters for the current functionality will remove the ability to change the plot of the previously calculated data. Is this intended? |
Works nicely. The configuration where after plotting something, then chaning a parameter (but not calculating!) you are then unable to select anything from the plotting fields is logical, as it could be misleading when there are different parameters on the screen but the plot is from "old" data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Description (what might a Reviewer want to know)
-Problem: When the user selects plot parameters and calculates, the plot parameters are reset to the default values without being used.
-Solution: The disable the field when the shouldn't be used (e.g. plot sth that isn't yet calculated)
-We added a fieldset in details.html in order to create a container which can be disabled. Then we added disable_plot_fields() to disable these fields and called it.
-Tests: simply go to a step where you can calculate and plot (and are able to specify plot parameters).
PR checklist