-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
296 visualizing protein quantifications across all samples #314
296 visualizing protein quantifications across all samples #314
Conversation
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)protzilla/constants/location_mapping.py
protzilla/data_analysis/plots.py
protzilla/run_helper.py
|
y=lower_upper_y, | ||
fill="toself", | ||
name="Intensity Range", | ||
line=dict(color="silver"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that important but : Maybe add this color (and the others used) to Protzilla dicrete color sequence
"name": "Similarity", | ||
"type": "numeric", | ||
"min": -1, | ||
"max": 999, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a litte confusing that you can increase the values with the arrows in whole numbers only, when you can (and for a good graph, should) input decimals, but otherwise looks good :)
…cations-across-all-samples' into 296-visualizing-protein-quantifications-across-all-samples
Description (what might a Reviewer want to know)
PR checklist