Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

296 visualizing protein quantifications across all samples #314

Merged

Conversation

lucatreide
Copy link
Collaborator

  • fixes #

Description (what might a Reviewer want to know)

  • what methods did you move somewhere else (not written by yourself and therefore might not be related to the PR topic, this is no excuse for bad code!)

PR checklist

  • main-branch has been merged into local branch to resolve conflicts
  • tests and linter have passed AFTER local merge
  • at least one other dev reviewed and approved
  • documentation
  • tests

Copy link

github-actions bot commented Nov 29, 2023

Coverage report

The coverage rate went from 70.01% to 69.55% ⬇️
The branch rate is 63%.

26.92% of new lines are covered.

Diff Coverage details (click to unfold)

protzilla/constants/location_mapping.py

100% of new lines are covered (100% of the complete file).

protzilla/data_analysis/plots.py

24% of new lines are covered (62.3% of the complete file).
Missing lines: 292, 293, 296, 299, 305, 307, 312, 313, 315, 316, 318, 319, 320, 322, 323, 324, 326, 336, 337, 338, 339, 340, 345, 349, 350, 351, 353, 354, 356, 357, 368, 369, 379, 382, 392, 402, 412, 436

protzilla/run_helper.py

100% of new lines are covered (69.49% of the complete file).

@lucatreide lucatreide requested a review from gritlm December 13, 2023 10:58
y=lower_upper_y,
fill="toself",
name="Intensity Range",
line=dict(color="silver"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that important but : Maybe add this color (and the others used) to Protzilla dicrete color sequence

"name": "Similarity",
"type": "numeric",
"min": -1,
"max": 999,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a litte confusing that you can increase the values with the arrows in whole numbers only, when you can (and for a good graph, should) input decimals, but otherwise looks good :)

@selenabr selenabr changed the title WIP: 296 visualizing protein quantifications across all samples 296 visualizing protein quantifications across all samples Dec 13, 2023
…cations-across-all-samples' into 296-visualizing-protein-quantifications-across-all-samples
@selenabr selenabr merged commit 612b7e3 into main Dec 13, 2023
1 check passed
@henninggaertner henninggaertner deleted the 296-visualizing-protein-quantifications-across-all-samples branch December 20, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants