Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored nodes #302

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Colored nodes #302

merged 6 commits into from
Dec 12, 2023

Conversation

antonneubauer
Copy link
Collaborator

@antonneubauer antonneubauer commented Nov 15, 2023

added functionality to fullfil the linked issue

PR checklist

  • main-branch has been merged into local branch to resolve conflicts
  • tests and linter have passed AFTER local merge
  • at least one other dev reviewed and approved
  • documentation

@antonneubauer antonneubauer self-assigned this Nov 15, 2023
@antonneubauer
Copy link
Collaborator Author

P10636(1)

implementation:

Copy link

github-actions bot commented Nov 15, 2023

Coverage report

The coverage rate went from 70.21% to 70.01% ⬇️
The branch rate is 63%.

0% of new lines are covered.

Diff Coverage details (click to unfold)

ui/runs/views.py

0% of new lines are covered (12.91% of the complete file).
Missing lines: 819, 820, 821, 824, 825, 826, 827, 828, 829, 830, 831, 832

@henninggaertner
Copy link
Collaborator

As far as code goes. looks good. How can I test this though?

@henninggaertner henninggaertner self-requested a review November 28, 2023 16:47
@antonneubauer
Copy link
Collaborator Author

antonneubauer commented Dec 1, 2023

@henninggaertner In the issue, i wrote a little tutorial.
Ill send you some test data

@henninggaertner
Copy link
Collaborator

  • Moving groups of nodes is weird
  • spacing of nodes sometimes messed up if name is too long
  • (on linux, firefox) size of nodes is not correct for longer names

@antonneubauer
Copy link
Collaborator Author

I'll take a look at the moving-nodes problem, i thought i fixed this in the past. too bad :(
the spacing is a known problem and won't be fixed in this PR, if ever. Its pretty hard to fix this.
I'll have to take a look at the node sizes. If never seen that before so I'll have to investigate

@antonneubauer
Copy link
Collaborator Author

  1. i added a disclaimer for the cut-off node labels.
  2. i will take care of the node movement in a future PR, likely in the next 3 (working) weeks
  3. the spacing was already planned as future work. I will take a look at that in a while

@antonneubauer antonneubauer merged commit dd9018b into main Dec 12, 2023
1 check passed
@antonneubauer antonneubauer deleted the colored-nodes branch December 12, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color coded nodes in protein graphs
2 participants