Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protein Graphs - small adjustments #300

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Protein Graphs - small adjustments #300

merged 3 commits into from
Nov 17, 2023

Conversation

antonneubauer
Copy link
Collaborator

@antonneubauer antonneubauer commented Nov 15, 2023 •
edited
Loading

The branch name is a bit grand for what happened in the end. Just moved some stuff around and took care of some obvious mishaps like missing/faulty doc strings.

  • moved _create_protein_variation_graph within the file
  • added/improved doc strings
  • wrap strings or add pep8 linter hints

PR checklist

  • main-branch has been merged into local branch to resolve conflicts
  • tests and linter have passed AFTER local merge
  • at least one other dev reviewed and approved
  • documentation

@github-actions GitHub Actions
Copy link

Coverage report

The coverage rate went from 71.42% to 71.42% ➡️
The branch rate is 64%.

96.42% of new lines are covered.

Diff Coverage details (click to unfold)

protzilla/data_analysis/protein_graphs.py

96.42% of new lines are covered (91.63% of the complete file).
Missing lines: 272

@antonneubauer antonneubauer requested a review from gritlm November 15, 2023 15:02
@antonneubauer antonneubauer self-assigned this Nov 15, 2023
@antonneubauer antonneubauer changed the title Protein graphs refactoring Prtein Graphs - small adjustments Nov 15, 2023
@antonneubauer antonneubauer changed the title Prtein Graphs - small adjustments Protein Graphs - small adjustments Nov 15, 2023
gritlm
gritlm approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@gritlm gritlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@gritlm gritlm merged commit ef04379 into main Nov 17, 2023
1 check passed
@antonneubauer antonneubauer deleted the protein-graphs-refactoring branch November 25, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gritlm gritlm gritlm approved these changes

Assignees

@antonneubauer antonneubauer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonneubauer @gritlm