Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

294 imputation using normal distribution sampling #299

Merged
merged 10 commits into from
Nov 17, 2023

Conversation

henninggaertner
Copy link
Collaborator

@henninggaertner henninggaertner commented Nov 14, 2023

Description (what might a Reviewer want to know)

  • nothing noteworthy, only implemented new imputation method, associated plot method (which is the same for all imputation methods) and created associated location mappings in location_mapping.py
  • this imputation method basically calculates the most fitting normal distribution for the data, then creates a new normal dist. by downshifting the mean and scaling the sd, then samples it to replace missing values. (can be done per protein group or over entire dataset)

PR checklist

  • main-branch has been merged into local branch to resolve conflicts
  • tests and linter have passed AFTER local merge
  • at least one other dev reviewed and approved
  • documentation
  • tests

@henninggaertner henninggaertner added the enhancement New feature or request label Nov 14, 2023
@henninggaertner henninggaertner linked an issue Nov 14, 2023 that may be closed by this pull request
5 tasks
…sampel ND, do not impute if there are insufficient values in dataframe
Repository owner deleted a comment from github-actions bot Nov 15, 2023
Copy link

github-actions bot commented Nov 15, 2023

Coverage report

The coverage rate went from 71.42% to 71.09% ⬇️
The branch rate is 64%.

72% of new lines are covered.

Diff Coverage details (click to unfold)

protzilla/constants/location_mapping.py

100% of new lines are covered (100% of the complete file).

protzilla/data_preprocessing/imputation.py

72% of new lines are covered (73.07% of the complete file).
Missing lines: 265, 268, 271, 274, 286, 289, 292, 297, 299, 302, 305, 319, 322, 325

@JanniRoebbecke JanniRoebbecke merged commit 74ce2cf into main Nov 17, 2023
1 check passed
@JanniRoebbecke JanniRoebbecke deleted the 294-imputation-using-normal-distribution-sampling branch November 17, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imputation using normal distribution sampling
2 participants