Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add other architectures #295

Merged
merged 1 commit into from
Nov 8, 2023
Merged

add other architectures #295

merged 1 commit into from
Nov 8, 2023

Conversation

selenabr
Copy link
Collaborator

@selenabr selenabr commented Nov 8, 2023

  • edit#295

added other architectures to .gitignore

PR checklist

  • main-branch has been merged into local branch to resolve conflicts
  • tests and linter have passed AFTER local merge
  • at least one other dev reviewed and approved
  • documentation
  • tests

Copy link

github-actions bot commented Nov 8, 2023

Coverage report

The coverage rate went from 71.42% to 71.42% ➡️
The branch rate is 64%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@selenabr selenabr requested a review from hendraet November 8, 2023 17:29
@henninggaertner henninggaertner removed the request for review from hendraet November 8, 2023 17:29
@henninggaertner henninggaertner merged commit f577b51 into main Nov 8, 2023
1 check passed
Comment on lines 147 to +149
Miniconda3-latest-Linux-x86_64.sh
Miniconda3-latest-MacOSX-x86_64.sh
Miniconda3-latest.exe
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to bother you again, but maybe you could go for sth. even more general 😅

(Please check if this actually works)

Suggested change
Miniconda3-latest-Linux-x86_64.sh
Miniconda3-latest-MacOSX-x86_64.sh
Miniconda3-latest.exe
Miniconda3*.sh
Miniconda3*.exe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants