Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix existing code style inconsistencies using pre-commit hooks #291

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Fix existing code style inconsistencies using pre-commit hooks #291

merged 2 commits into from
Nov 6, 2023

Conversation

henninggaertner
Copy link
Collaborator

@henninggaertner henninggaertner commented Nov 6, 2023 •
edited
Loading

  • fixes incosistencies regarding python imports
  • also fix a spelling mistake

PR checklist

  • main-branch has been merged into local branch to resolve conflicts
  • tests and linter have passed AFTER local merge
  • at least one other dev reviewed and approved
  • documentation
  • tests

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Coverage report

The coverage rate went from 71.42% to 71.42% ➡️
The branch rate is 64%.

60% of new lines are covered.

Diff Coverage details (click to unfold)

protzilla/data_preprocessing/imputation.py

100% of new lines are covered (95.45% of the complete file).

ui/main/views.py

0% of new lines are covered (0% of the complete file).
Missing lines: 2, 5

@henninggaertner henninggaertner changed the title Fix existing code style incosistencies using pre-commit hooks Fix existing code style inconsistencies using pre-commit hooks Nov 6, 2023
@JanniRoebbecke JanniRoebbecke merged commit d4d7dac into main Nov 6, 2023
1 check passed
@henninggaertner henninggaertner deleted the pre-commit-for-all-files branch November 30, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henninggaertner @antonneubauer @JanniRoebbecke