-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move calculation and plot methods #17
Conversation
test for reference protein normalisation is not working
…plot-methods # Conflicts: # protzilla/history.py # protzilla/run.py # tests/protzilla/test_history.py # tests/protzilla/test_run.py
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)protzilla/constants/paths.py
protzilla/run_manager.py
protzilla/data_preprocessing/plots.py
protzilla/importing/ms_data_import.py
tests/protzilla/data_preprocessing/test_filter_proteins.py
protzilla/data_preprocessing/outlier_detection.py
protzilla/data_preprocessing/normalisation.py
protzilla/utilities/transform_dfs.py
tests/protzilla/data_preprocessing/test_transformation.py
protzilla/workflow_manager.py
tests/protzilla/test_run.py
protzilla/run.py
protzilla/constants/constants.py
protzilla/history.py
protzilla/data_preprocessing/filter_samples.py
tests/protzilla/data_preprocessing/test_imputation.py
protzilla/data_preprocessing/filter_proteins.py
tests/conftest.py
protzilla/data_preprocessing/imputation.py
tests/protzilla/data_preprocessing/test_normalisation.py
tests/protzilla/data_preprocessing/test_plots.py
protzilla/data_preprocessing/transformation.py
tests/protzilla/test_history.py
protzilla/constants/location_mapping.py
tests/protzilla/data_preprocessing/test_outlier_detection.py
tests/protzilla/data_preprocessing/test_filter_samples.py
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few small suggestions and commented on some ideas I had.
In addition: I think the tests for filter_samples is missing if I'm not mistaken. Was that by accident or am I overlooking them?
Good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks overall good apart from some minor changes that I think would make sense.
Also: the formatting is broken in many of the files and you should check if your pre-commit hook works properly.
Good work as far as I am concerned!
Co-authored-by: antonneubauer <[email protected]>
…m/antonneubauer/PROTzilla2 into move-calculation-and-plot-methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk how you managed to change almost all files without visibly changing them but the parts that actually did look good now!
PR for #9
The methods
by_low_frequency
,by_median
,by_totalsum
andby_reference_protein
were moved to PROTzilla2. Each method has its corresponding functionby_low_frequency_plot
,by_median_plot
,by_totalsum_plot
andby_reference_protein_plot
, that returns the plot for the corresponding method.Also the tests for this methods were moved to PROTzilla2 and fixtures are now used for the setup.
Analogously to the
perform_calculation_from_location
andperform_calculation
, the methodscreate_plot_from_location
andcreate_plot
call the corresponding plot with the appropriate parameters. For this purpose it also exists aplot_map
.