Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add option to disable versioning in EOS upon PUT request #4864

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Nov 11, 2024

  1. Implemented RegisterGatewayServiceClient

    Implemented a new function to register a GatewayServiceClient. Previously, this could only be done by passing an actual connection. However, that is unnecessarily limiting. Introducing the RegisterGatewayServiceClient allows us to register mocked gateways for unit testing
    Jesse Geens committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a30a0ba View commit details
    Browse the repository at this point in the history
  2. Implemented X-Disable-Versioning header to disable versioning on EOS

    This commit introduces a new header, `X-Disable-Versioning`, that is available on PUT requests. This header will disable versioning for this file save if the storage backend is EOS.
    
    Additionally, this commit introduces two unit tests related to this functionality:
    - TestDisableVersioningLeadsToCorrectQueryParams: test whether disabling versioning leads to correct query parameteers for the EOS HTTP / GRPC client
    - TestDisableVersioningHeaderPassedAlong: test whether a header passed to the initial endpoint is propagated to the actual upload endpoint
    
    Finally, this commit also fixes a bug that was already present, where
    the app was not passed along in the case of token-based authz
    Jesse Geens committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    78191f9 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Configuration menu
    Copy the full SHA
    7400b40 View commit details
    Browse the repository at this point in the history