Tusd PATCH Checksums #4807
Draft
Tusd PATCH Checksums #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobergj
force-pushed
the
TusdPatchChecksums
branch
from
7217b85
to
57a129d
Compare
butonic
reviewed
Aug 14, 2024
| } | ||
| switch strings.ToLower(parts[0]) { | ||
| case "sha1": | ||
| return checkHash(parts[1], sha1h) |
There was a problem hiding this comment.
afaict checkHash still needs to base64 decode the checksum
There was a problem hiding this comment.
Won't work. We also use this function to compare checksums from upload sessions (which are not base64 encoded). I added a bool parameter to reflect that.
kobergj
force-pushed
the
TusdPatchChecksums
branch
2 times, most recently
from
da601fd
to
ec07223
Compare
Signed-off-by: jkoberg <[email protected]>
kobergj
force-pushed
the
TusdPatchChecksums
branch
from
ec07223
to
4b6a99d
Compare
|
running into ankitpokhrel/tus-php#422 :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compares checksums in PATCH requests during chunked uploads