Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto pypi release #210

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Add auto pypi release #210

merged 1 commit into from
Feb 8, 2024

Conversation

montyly
Copy link
Member

@montyly montyly commented Feb 8, 2024

Summary by CodeRabbit

  • New Features
    • Automated publishing of Python packages to PyPI upon a release event, including artifact signing for trusted publishing.

@montyly montyly requested a review from S3v3ru5 as a code owner February 8, 2024 13:53
Copy link

coderabbitai bot commented Feb 8, 2024

Walkthrough

This update introduces an automated workflow for publishing Python packages to PyPI via GitHub Actions. It activates upon a release event, streamlining the process of building, signing, and uploading package distributions. This ensures a secure and efficient delivery of updates to PyPI, enhancing trust and simplifying the release process for developers.

Changes

File Summary
.github/workflows/publish.yml Introduced a GitHub Actions workflow for automating Python package releases to PyPI, including artifact signing with Sigstore.

🐇✨
In the world of code, a rabbit hops,
Bringing packages to PyPI's top.
With each release, it leaps and bounds,
In GitHub Actions, its magic astounds.
🚀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9817d18 and 3aea38a.
Files selected for processing (1)
  • .github/workflows/publish.yml (1 hunks)
Additional comments: 2
.github/workflows/publish.yml (2)
  • 3-5: Ensure the trigger event configuration aligns with the intended use case. If additional release types should trigger this workflow, consider expanding the types array.
  • 32-54: The publishing and signing steps are well-defined. However, verify the permissions set in line 36 and 37 are strictly necessary for the operations performed in this job to adhere to the principle of least privilege.

Comment on lines +12 to +24
steps:
- uses: actions/checkout@v4

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.x'

- name: Build distributions
run: |
python -m pip install --upgrade pip
python -m pip install build
python -m build
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build process is correctly set up. However, consider caching the installed Python packages to speed up the workflow runs.

+      - name: Cache pip
+        uses: actions/cache@v3
+        with:
+          path: ~/.cache/pip
+          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
+          restore-keys: |
+            ${{ runner.os }}-pip-

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
steps:
- uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.x'
- name: Build distributions
run: |
python -m pip install --upgrade pip
python -m pip install build
python -m build
steps:
- uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.x'
- name: Cache pip
uses: actions/cache@v3
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
restore-keys: |
${{ runner.os }}-pip-
- name: Build distributions
run: |
python -m pip install --upgrade pip
python -m pip install build
python -m build

Comment on lines +47 to +54
- name: publish
uses: pypa/[email protected]

- name: sign
uses: sigstore/[email protected]
with:
inputs: ./dist/*.tar.gz ./dist/*.whl
release-signing-artifacts: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding error handling for the publishing and signing steps to manage failures gracefully.

+      - name: publish
+        uses: pypa/[email protected]
+        continue-on-error: true
+
+      - name: sign
+        uses: sigstore/[email protected]
+        with:
+          inputs: ./dist/*.tar.gz ./dist/*.whl
+          release-signing-artifacts: true
+          bundle-only: true
+        continue-on-error: true

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
- name: publish
uses: pypa/[email protected]
- name: sign
uses: sigstore/[email protected]
with:
inputs: ./dist/*.tar.gz ./dist/*.whl
release-signing-artifacts: true
- name: publish
uses: pypa/[email protected]
continue-on-error: true
- name: sign
uses: sigstore/[email protected]
with:
inputs: ./dist/*.tar.gz ./dist/*.whl
release-signing-artifacts: true
bundle-only: true
continue-on-error: true

@montyly montyly merged commit 22bc8d5 into main Feb 8, 2024
23 checks passed
@montyly montyly deleted the pypi-release branch February 8, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant