Add pure-Rust Blake2 #755
Open
Add pure-Rust Blake2 #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,13 @@ | |||
| //#![no_std] | |||
There was a problem hiding this comment.
Is it supposed to be no_std? alloc is used unconditionally right now, so it won't be no_std without changes.
| @@ -0,0 +1,6 @@ | |||
| pub fn memzero<T: Copy>(x: &mut [T], len: u32) { | |||
There was a problem hiding this comment.
Let's not use this memzero. It won't actually do anything. Let's throw in proper zeroization into a new crate that we already have on the secret ints branch. Or not do it at all. But using this looks bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the pure-rust implementation from hacl-rs. So far this only features a low-level byte-oriented API.
One thing I am not sure about is the
last_nodeflag. From reading the spec I think it maybe should be set totrue, but that makes it produce wrong/inconsistent results.It also reduces the visibility of some hacl-related submodules of ed25519, that is an unrelated cleanup change.