Introduce AVX2 target_feature boundary in x4 sampling
#719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to have a `target_feature` boundary here as well.
We check the length beforehand.
franziskuskiefer
approved these changes
Dec 18, 2024
- Comment location - Remove `sample_four_ring_elements_into!` macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR takes @franziskuskiefer's work on introducing another target feature boundary in x4 sampling for ring elements.
I've introduced a new enum that selects which sampler to use and allows switching on the target feature for AVX2.
Also, I tried to write
SampleArgsa bit more generically, in case we want to do the same for error sampling.