Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update C extraction Docker file #408

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Update C extraction Docker file #408

merged 1 commit into from
Jul 17, 2024

Conversation

jschneider-bensch
Copy link
Collaborator

This PR is a first step towards getting C extraction on CI:

  • Update the revisions of HACL*, Charon, Karamel and Eurydice to their current latest main branch state.
  • Fix depencencies for these tools in the Docker image.

With this, the image could be published I think.

franziskuskiefer
franziskuskiefer approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you make sure it works in the uploaded container (franziskus/libcrux-c)?

@jschneider-bensch
Copy link
Collaborator Author

I checked c.sh and boring.sh, both work with the uploaded container 👍.

@jschneider-bensch jschneider-bensch merged commit 45d799c into main Jul 17, 2024
48 checks passed
@jschneider-bensch jschneider-bensch deleted the jonas/c-extraction-docker branch July 17, 2024 13:56
@franziskuskiefer franziskuskiefer mentioned this pull request Jul 18, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschneider-bensch @franziskuskiefer