-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularized PSQ #401
Modularized PSQ #401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! lgtm in general. I left some comments on the code (not protocol, that looks fine).
We know the content (or its size, rather) of the AEAD ciphertext as well, so I could use the non-allocating API there, too. |
Review re-requested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, let's get this in and then iterate.
It would be great if you would add a usage example in the lib docs os there's an easy starting point.
This PR modularizes the PSQ protocol into