Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up scaffolding for vectorization. #367

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

xvzcf
Copy link
Contributor

@xvzcf xvzcf commented Jul 7, 2024

I moved the code for PolynomialRingElement into polynomial.rs, and in order to facilitate the transition towards a vectorized codebase, I added another struct to polynomial.rs called VectorPolynomialRingElement:

VectorPolynomialRingElement contains functions to convert to and from a PolynomialRingElement. This way I can incrementally make changes to the codebase; eventually PolynomialRingElement will be removed and VectorPolynomialRingElement will be take its place. An example of how this works can be seen here.

Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The restructure looks good. The real test will be when we add a new implementation of the ring element.

@franziskuskiefer franziskuskiefer merged commit 1727de0 into main Jul 8, 2024
49 checks passed
@franziskuskiefer franziskuskiefer deleted the goutam/ml-dsa-vec-setup branch July 8, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants