Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop libcrux dependency in libcrux-ecdh #347

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Drop libcrux dependency in libcrux-ecdh #347

merged 1 commit into from
Jul 3, 2024

Conversation

jschneider-bensch
Copy link
Collaborator

This PR gets rid of the libcrux dependency for testing in libcrux-ecdh. To do this, I've replaced the libcrux Drbg with OsRng, that was previously only used for the wasm32 target.

franziskuskiefer
franziskuskiefer approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@franziskuskiefer franziskuskiefer merged commit 5ee59d7 into dev Jul 3, 2024
46 checks passed
@franziskuskiefer franziskuskiefer deleted the jonas/ecdh-deps branch July 3, 2024 06:56
@jschneider-bensch jschneider-bensch mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschneider-bensch @franziskuskiefer