Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More benchmarks and ct #343

Merged
merged 5 commits into from
Jul 2, 2024
Merged

More benchmarks and ct #343

merged 5 commits into from
Jul 2, 2024

Conversation

franziskuskiefer
Copy link
Member

No description provided.

@franziskuskiefer franziskuskiefer mentioned this pull request Jul 2, 2024
Merged
jschneider-bensch
jschneider-bensch reviewed Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@jschneider-bensch jschneider-bensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Rust code looks good to me, but the C build seems to fail?

libcrux-ml-kem/src/constant_time_ops.rs Show resolved Hide resolved
@franziskuskiefer
Copy link
Member Author

The Rust code looks good to me, but the C build seems to fail?

Ah, select is a function the stdlib that conflicts. I'll change the name ...

@franziskuskiefer
don't use as function name
e565afe 
This conflicts with a function in the C stdlib
@franziskuskiefer franziskuskiefer merged commit 86efd54 into dev Jul 2, 2024
47 checks passed
@franziskuskiefer franziskuskiefer deleted the franziskus/more-ct branch July 2, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschneider-bensch jschneider-bensch jschneider-bensch approved these changes

@karthikbhargavan karthikbhargavan Awaiting requested review from karthikbhargavan

Assignees
No one assigned
Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franziskuskiefer @jschneider-bensch