Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Vector code in ML-KEM to split functionality #328

Merged
merged 10 commits into from
Jun 27, 2024

Conversation

karthikbhargavan
Copy link
Contributor

This PR makes the structure of the 3 vector implementations uniform by using the same module names for AVX2, Neon, and Portable. It also breaks up the monolithic portable code in vector.rs into multiple modules.

@karthikbhargavan
Copy link
Contributor Author

I added a drive-by fix for a C compilation error (implicit conversion from 'int' to 'short' changes value from 32768 to -32768)

@franziskuskiefer franziskuskiefer changed the base branch from main to dev June 21, 2024 06:19
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you update the C code with this to make sure this is working?

@karthikbhargavan
Copy link
Contributor Author

I regenerated and tested the C code, but I would love it if someone else could also check that this works (once CI is happy)

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthikbhargavan there's a conflict. Can you resolve that? Then we can get this merged.

I tested the C code. It works fine on arm-based macOS and x64. CI says the same.

You committed the neon files again though. They don't do anything, but we also don't use them.

@karthikbhargavan karthikbhargavan merged commit 2ebae74 into dev Jun 27, 2024
47 checks passed
@karthikbhargavan karthikbhargavan deleted the dev_vector_restruct branch June 27, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants