Expose the SHAKE-128 incremental API in libcrux and add 100,000 Kyber KAT tests using this API #156
Conversation
| @@ -1004,462 +998,3 @@ extern "C" { | |||
| key_len: u32, | |||
| ); | |||
| } | |||
| extern "C" { | |||
There was a problem hiding this comment.
To regenerate the bindings correctly you need to build for an x64 target. That's the only one that has all the features.
| .allowlist_function("Hacl_Hash_.*") | ||
| .allowlist_function("Hacl_Blake2.*") | ||
| .allowlist_function("Hacl_Hash_SHA3.*") | ||
| .allowlist_function("Hacl_Hash_Blake2.*") |
There was a problem hiding this comment.
What's the reason to list all of these explicitely now?
There was a problem hiding this comment.
I thought it would just document better what exactly we want and what we don't want. Also, this let me exclude Hacl_Hash_SHA3_Scalar_sha3*, Hacl_Hash_SHA3_Scalar_shake128 and the like from the extraction (they weren't being used and I didn't want to add them in).
|
This is blocked on fixing the includes for avx2 in cryspen/hacl-packages#443. |
|
Is this PR still alive @xvzcf? |
I think the SHA3 incremental API is exposed, but I don't think we have the 100k KAT test, I can open a fresh PR adding that. |
No description provided.