Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic instead of returning an error in rejection sampling if 5 blocks of SHAKE aren't enough #151

Merged
merged 7 commits into from
Dec 8, 2023
Merged

Panic instead of returning an error in rejection sampling if 5 blocks of SHAKE aren't enough #151

merged 7 commits into from
Dec 8, 2023

Conversation

xvzcf
Copy link
Contributor

@xvzcf xvzcf commented Dec 7, 2023

No description provided.

karthikbhargavan
karthikbhargavan approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall both the source code and generated code look much nicer, so I support this change.

src/kem/kyber/sampling.rs Outdated Show resolved Hide resolved
@franziskuskiefer
Copy link
Member

@xvzcf looks like CI is failing

@xvzcf
Copy link
Contributor Author

xvzcf commented Dec 7, 2023 •
edited
Loading

@xvzcf looks like CI is failing

Yup, Karthik will give the panicking function the right type in Fstar.

franziskuskiefer
franziskuskiefer approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in.

@franziskuskiefer franziskuskiefer merged commit cb5785e into dev Dec 8, 2023
15 checks passed
@franziskuskiefer franziskuskiefer deleted the rejection-sampling-panic branch December 8, 2023 10:42
@franziskuskiefer franziskuskiefer mentioned this pull request Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

@protz protz Awaiting requested review from protz

@karthikbhargavan karthikbhargavan Awaiting requested review from karthikbhargavan

Assignees
No one assigned
Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xvzcf @franziskuskiefer @karthikbhargavan