Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring #111

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Minor refactoring #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f072f9e
Remove benchmarking of Kyber specification.
xvzcf Oct 11, 2023
5a2853a
Removed unused variable in extract_to_fstar.py
xvzcf Oct 11, 2023
bb66dcf
Forgot to update Cargo.toml
xvzcf Oct 11, 2023
e0bdabf
Skip Kyber specification sampling tests for now.
xvzcf Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions extract_to_fstar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import sys


def shell(command, expect=0, cwd=None, format_filter_string=False):
def shell(command, expect=0, cwd=None):
subprocess_stdout = subprocess.DEVNULL

print("Command: ", end="")
Expand Down Expand Up @@ -101,7 +101,6 @@ def shell(command, expect=0, cwd=None, format_filter_string=False):
"fstar",
],
cwd=options.crate_path,
format_filter_string=True,
)
elif options.kyber_reference:
shell(
Expand All @@ -114,7 +113,6 @@ def shell(command, expect=0, cwd=None, format_filter_string=False):
"fstar",
],
cwd=".",
format_filter_string=True,
)
else:
shell(["cargo", "hax", "into", "fstar"], cwd=options.crate_path)
5 changes: 0 additions & 5 deletions specs/kyber/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,9 @@ libcrux = { version = "=0.0.2-pre.1", path = "../../" }
hacspec-lib = { version = "0.0.1", path = "../hacspec-lib" }

[dev-dependencies]
criterion = "0.5.1"
hex = { version = "0.4.3", features = ["serde"] }
pqcrypto-kyber = { version = "0.7.6", default-features = false }
proptest = "1.2.0"
rand = "0.8.5"
serde = { version = "1.0.171", features = ["derive"] }
serde_json = "1.0.102"

[[bench]]
name = "kem"
harness = false
122 changes: 0 additions & 122 deletions specs/kyber/benches/kem.rs
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions specs/kyber/src/sampling.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ mod tests {

proptest! {
#[test]
#[ignore = "see https://github.com/cryspen/libcrux/issues/112"]
fn uniform_sampler_mean_and_variance(randomness in vec(any::<u8>(), REJECTION_SAMPLING_ATTEMPTS * parameters::REJECTION_SAMPLING_SEED_SIZE)) {
let mut sampled_ring_element = KyberPolynomialRingElement::ZERO;

Expand Down Expand Up @@ -277,6 +278,7 @@ mod tests {
}

#[test]
#[ignore = "see https://github.com/cryspen/libcrux/issues/112"]
fn binomial_sampler_mean_and_variance(
randomness in vec(any::<u8>(), 2 * 2 * 64)
)
Expand Down