Add feature kyber for Round 3 Kyber API (#327)

* Revert changes to Kyber (Round 3) for ML-KEM * Fix swapped private key decoding * Pull out Kyber encaps * Make Kyber API available behind `kyber` feature * Format * Introduce `kyber` feature in `libcrux-kem` * Format * fix C extraction * Fix typo * Give more accurate test names (`kyber...` to `mlkem...`) * Avoid unused warning when testing * Use `Hasher` trait to select best KDF for Kyber * Document differences between Kyber (Round 3) and ML-KEM * Inline ML-KEM/Kyber variant differences * `kyber{512,768,1024}` top level modules * Fix `kyber` feature in `libcrux-kem` * Rename NIST KAT files for ML-KEM * Include NIST KATs for all Kyber parameter sets * Document single Kyber 768 KAT from boringssl * Format * Test Kyber on CI * update code for C generation Also drop unused test feature in ml-kem crate * update generated C code --------- Co-authored-by: Franziskus Kiefer <[email protected]>
cryspen · Jun 26, 2024 · 9018f21 · 9018f21
1 parent 2b2031d
commit 9018f21
Show file tree

Hide file tree

Showing 60 changed files with 4,402 additions and 330 deletions.
diff --git a/.github/workflows/mlkem.yml b/.github/workflows/mlkem.yml
@@ -145,6 +145,12 @@ jobs:
           cargo clean
           LIBCRUX_DISABLE_SIMD128=1 LIBCRUX_DISABLE_SIMD256=1 cargo test --verbose --release $RUST_TARGET_FLAG
 
+      - name: 🏃🏻‍♀️ Test Kyber
+        run: |
+          cargo clean
+          cargo test --features kyber --verbose $RUST_TARGET_FLAG
+
+
   benchmarks:
     strategy:
       fail-fast: true

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/benchmarks/Cargo.toml b/benchmarks/Cargo.toml
@@ -14,7 +14,7 @@ publish = false
 [dev-dependencies]
 libcrux = { path = "../", features = ["rand", "tests"] }
 libcrux-kem = { path = "../libcrux-kem", features = ["tests"] }
-libcrux-ml-kem = { path = "../libcrux-ml-kem", features = ["tests"] }
+libcrux-ml-kem = { path = "../libcrux-ml-kem" }
 rand = { version = "0.8" }
 rand_core = { version = "0.6" }
 # Benchmarking "RustCrypto"

diff --git a/libcrux-kem/Cargo.toml b/libcrux-kem/Cargo.toml
@@ -20,6 +20,7 @@ rand = { version = "0.8" }
 
 [features]
 tests = [] # Expose functions for testing.
+kyber = ["libcrux-ml-kem/kyber"]
 
 [dev-dependencies]
 libcrux-kem = { version = "0.0.2-pre.2", path = "./", features = ["tests"] }