Charon traits merge #553
Merged
Charon traits merge #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W95Psp
force-pushed
the
charon_traits_merge
branch
3 times, most recently
from
cfd1e70 to
c25761c
Compare
W95Psp
force-pushed
the
charon_traits_merge
branch
from
c25761c to
99ca4ac
Compare
W95Psp
force-pushed
the
charon_traits_merge
branch
2 times, most recently
from
e11cbe9 to
a515aef
Compare
W95Psp
force-pushed
the
charon_traits_merge
branch
from
b0802bb to
44b259d
Compare
W95Psp
force-pushed
the
charon_traits_merge
branch
from
b92c568 to
5ce94c4
Compare
Some of the structure of the type that are used in the THIR/MIR AST changed, thus some hashes changed as well.
|
On my side, I'm OK with the changes introduced in this PR. @franziskuskiefer, I'm postponing tests on MIR to #481: I have no time for that, and this PR has been waiting for too long, Son needs it. However, I think we need to have #481 as soon as possible: let's plan that next Thursday at CC. EDIT: seems like there is a regression. When extracting curve25519 from the specs repo, the frontend seemlingly produces unsafe blocks... |
The ImplExpr resolution was calling into `mir` helpers, which is failing on some test. We don't use this information in hax for THIR, so I'm just dropping that info for now.
Hax relies on span equality for uninlining macro calls, this was broken since there is no way to recover `rust_span_data` when parsing it back from the engine.
W95Psp
force-pushed
the
charon_traits_merge
branch
from
02a88b9 to
0274953
Compare
franziskuskiefer
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo list:
[ ] Add tests for MIR extraction in hax: see CI: test the frontend (THIR+MIR) on a list of given crate #481[ ] Check if the changes are fine in charon: this will be done in follow up PRS