Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spotbit api url and path #2372

Merged

Conversation

BBlackwo
Copy link
Contributor

@BBlackwo BBlackwo commented Aug 29, 2023

Closes #2381

Fixed

Outstanding issues

Some outstanding issues (not sure if I'll have time to fix them all though):

  • Not sure why the test is failing as it seems like it's supposed to be ignoring spotbit entirely...
  • The default spotbit configuration now supports mostly different exchanges than what Specter is expecting (see https://github.com/BlockchainCommons/spotbit/blob/master/spotbit.config). It seems Specter should maybe run its own Spotbit server to be able to customise this?
  • The historical API has changed to use start and end query parameter date time strings instead of path parameters

@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for specter-desktop-docs canceled.

Name Link
🔨 Latest commit eb438ef
🔍 Latest deploy log https://app.netlify.com/sites/specter-desktop-docs/deploys/650ac85dc5287d0008983ccd

@BBlackwo BBlackwo force-pushed the fix/update-spotbit-onion-service-url branch from e3855ba to be3f8e5 Compare August 30, 2023 12:38
@BBlackwo BBlackwo changed the title Update spotbit onion service url Update spotbit api url and path Aug 30, 2023
@k9ert
Copy link
Collaborator

k9ert commented Sep 19, 2023

Tests are now green. But that was only something formal as this is not covered by tests.
Running our own spotbit-server is not really an option. I guess we should rather adjust to what spotbit is providing. In
685f041 i've removed the invalid ones and added gemini for now. I tried Binance as well but that didn't work out as usd is not supported for binance on spotbit and the other currencies had no data.
Haven't tried the other ones.

@k9ert
Copy link
Collaborator

k9ert commented Sep 19, 2023

I've also looked at the history API and hopefully have fixed it. Can you test that? Thanks for your work :-) .

@BBlackwo
Copy link
Contributor Author

Spotbit is down at the moment so might be difficult to test 😅 BlockchainCommons/spotbit#105

@k9ert
Copy link
Collaborator

k9ert commented Sep 20, 2023

Ok, let's assume the best. As i'm doing a release soon and it's couldn't get worse than "not working", i'm merging this right now.

@k9ert k9ert merged commit 6a51d31 into cryptoadvance:master Sep 20, 2023
@BBlackwo
Copy link
Contributor Author

Ok great thanks for finishing the PR off! 🙂

@BBlackwo BBlackwo deleted the fix/update-spotbit-onion-service-url branch September 20, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotbit price provider does not work
2 participants