Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: tx evm raw doesn't work under offline #524

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Sep 13, 2024

add evm-denom flag

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.07%. Comparing base (56f8a5b) to head (d9b2a6e).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
x/evm/client/cli/tx.go 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #524      +/-   ##
===========================================
- Coverage    60.11%   60.07%   -0.04%     
===========================================
  Files          128      128              
  Lines         9821     9827       +6     
===========================================
  Hits          5904     5904              
- Misses        3336     3342       +6     
  Partials       581      581              
Files with missing lines Coverage Δ
x/evm/client/cli/tx.go 0.00% <0.00%> (ø)

@mmsqe mmsqe changed the title Problem: tx evm raw doesn't work under offline mode Problem: tx evm raw doesn't work under offline Sep 13, 2024
@mmsqe mmsqe marked this pull request as ready for review September 13, 2024 09:41
@yihuang yihuang enabled auto-merge (squash) September 13, 2024 09:41
@yihuang yihuang merged commit dbc7eb4 into crypto-org-chain:develop Sep 13, 2024
36 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants