Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: disable of create vesting account messages are not complete #506

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Aug 1, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe requested a review from yihuang August 1, 2024 10:28
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: mmsqe <[email protected]>
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.56%. Comparing base (c36b266) to head (5adc613).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #506   +/-   ##
========================================
  Coverage    61.55%   61.56%           
========================================
  Files          128      128           
  Lines         9499     9501    +2     
========================================
+ Hits          5847     5849    +2     
  Misses        3112     3112           
  Partials       540      540           
Files Coverage Δ
app/app.go 76.37% <100.00%> (+0.08%) ⬆️

@mmsqe mmsqe enabled auto-merge (squash) August 1, 2024 13:07
@mmsqe mmsqe merged commit b0022ea into crypto-org-chain:develop Aug 1, 2024
38 of 39 checks passed
mmsqe added a commit that referenced this pull request Aug 2, 2024
)

* Optimize AnteHandle method to skip checks if disabledMsgs is empty

* Problem: cometbft not up to date (#505)

include the fix from cometbft/cometbft#3196

* Problem: disable of create vesting account messages are not complete (#506)

* Problem: disable of create vesting account messages are not complete

* Update CHANGELOG.md

Signed-off-by: mmsqe <[email protected]>

---------

Signed-off-by: mmsqe <[email protected]>

* CHANGELOG

* Update CHANGELOG.md

Signed-off-by: mmsqe <[email protected]>

---------

Signed-off-by: mmsqe <[email protected]>
Signed-off-by: fx0x55 <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: mmsqe <[email protected]>
@mmsqe mmsqe deleted the disable_vest branch August 6, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants