Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize AnteHandle method to skip checks if disabledMsgs is empty #504

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

fx0x55
Copy link

@fx0x55 fx0x55 commented Aug 1, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.54%. Comparing base (b0022ea) to head (6577b66).

Files Patch % Lines
app/ante/authz.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #504      +/-   ##
===========================================
- Coverage    61.56%   61.54%   -0.02%     
===========================================
  Files          128      128              
  Lines         9501     9503       +2     
===========================================
  Hits          5849     5849              
- Misses        3112     3113       +1     
- Partials       540      541       +1     
Files Coverage Δ
app/ante/authz.go 84.61% <0.00%> (-4.58%) ⬇️

@mmsqe mmsqe enabled auto-merge (squash) August 2, 2024 02:09
@mmsqe
Copy link
Collaborator

mmsqe commented Aug 2, 2024

Hi @fx0x55, can you help sign the first commit and add a change log?

auto-merge was automatically disabled August 2, 2024 02:37

Head branch was pushed to by a user without write access

@fx0x55
Copy link
Author

fx0x55 commented Aug 2, 2024

Hi @fx0x55, can you help sign the first commit and add a change log?

OK, done

CHANGELOG.md Outdated Show resolved Hide resolved
@mmsqe mmsqe enabled auto-merge (squash) August 2, 2024 03:04
@mmsqe
Copy link
Collaborator

mmsqe commented Aug 2, 2024

Hi @fx0x55, can you help sign the first commit and add a change log?

OK, done

Thanks, can you sign all the commits?
Screenshot 2024-08-02 at 11 28 55 AM

fx0x55 and others added 5 commits August 2, 2024 12:19
auto-merge was automatically disabled August 2, 2024 04:20

Head branch was pushed to by a user without write access

@fx0x55
Copy link
Author

fx0x55 commented Aug 2, 2024

Hi @fx0x55, can you help sign the first commit and add a change log?

OK, done

Thanks, can you sign all the commits? Screenshot 2024-08-02 at 11 28 55 AM

@mmsqe Ok, done

@mmsqe mmsqe enabled auto-merge (squash) August 2, 2024 04:23
@mmsqe mmsqe merged commit ff4caa1 into crypto-org-chain:develop Aug 2, 2024
37 of 39 checks passed
@fx0x55 fx0x55 deleted the empty branch August 2, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants