Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: benchmark logic don't increase nonce #502

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jul 29, 2024

Solution:

  • keep the benchmark logic closer to real one, only removing the nonce check part

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Solution:
- keep the benchmark logic closer to real one, only removing the nonce
  check part
@yihuang yihuang requested a review from mmsqe July 29, 2024 06:41
@yihuang yihuang enabled auto-merge (squash) July 29, 2024 06:46
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.55%. Comparing base (f3e62cb) to head (73996bb).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #502   +/-   ##
========================================
  Coverage    61.55%   61.55%           
========================================
  Files          128      128           
  Lines         9499     9499           
========================================
  Hits          5847     5847           
  Misses        3112     3112           
  Partials       540      540           
Files Coverage Δ
app/ante/eth.go 78.86% <100.00%> (+0.17%) ⬆️
app/ante/handler_options.go 61.11% <0.00%> (-0.43%) ⬇️

@yihuang yihuang merged commit 3509552 into crypto-org-chain:develop Jul 29, 2024
37 of 38 checks passed
@yihuang yihuang deleted the benchmark branch July 29, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants