forked from evmos/ethermint
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: tx format conversions not necessary #478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
added a commit
to yihuang/go-ethereum
that referenced
this pull request
Apr 24, 2024
the time field is a roadblock to reuse the Transaction type in an external system, remove it since we don't use it in ethermint/cronos. see: crypto-org-chain/ethermint#478
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #478 +/- ##
===========================================
- Coverage 62.93% 61.71% -1.22%
===========================================
Files 126 127 +1
Lines 9480 9442 -38
===========================================
- Hits 5966 5827 -139
- Misses 2974 3077 +103
+ Partials 540 538 -2
|
yihuang
force-pushed
the
cleanup-tx
branch
2 times, most recently
from
April 25, 2024 08:21
98a96cb
to
6c734fb
Compare
mmsqe
reviewed
Apr 25, 2024
mmsqe
reviewed
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems we might also need fix the data for raw
mmsqe
reviewed
Apr 26, 2024
mmsqe
approved these changes
Apr 26, 2024
Solution: - embed ethtypes.Transaction into MsgEthereumTx protobuf message as the core component. restore ValidateBasic fix json format cleanup fix json fix json
Signed-off-by: yihuang <[email protected]>
mmsqe
pushed a commit
to mmsqe/go-ethereum
that referenced
this pull request
Sep 24, 2024
the time field is a roadblock to reuse the Transaction type in an external system, remove it since we don't use it in ethermint/cronos. see: crypto-org-chain/ethermint#478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #471
Solution:
ethtypes.Transaction
type inside the protobuf message directly.Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)