Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: app utils triggers import cycle easily #477

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Apr 23, 2024

mv to testutil and config

prepare for #475

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe requested a review from yihuang April 23, 2024 01:31

import (
"encoding/json"
"math/rand"

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: go.lang.security.audit.crypto.math_random.math-random-used Warning test

Do not use math/rand. Use crypto/rand instead.
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.93%. Comparing base (b677927) to head (ee0677e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #477      +/-   ##
===========================================
- Coverage    63.09%   62.93%   -0.17%     
===========================================
  Files          127      126       -1     
  Lines         9631     9480     -151     
===========================================
- Hits          6077     5966     -111     
+ Misses        3007     2974      -33     
+ Partials       547      540       -7     
Files Coverage Δ
app/app.go 76.95% <ø> (ø)

... and 2 files with indirect coverage changes

@mmsqe mmsqe enabled auto-merge (squash) April 29, 2024 02:11
@mmsqe mmsqe merged commit 40463e8 into crypto-org-chain:develop Apr 29, 2024
37 of 38 checks passed
@yihuang yihuang deleted the cleanup_test branch April 29, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants