feature: debug_traceCall RPC support #384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Implemented the RPC
…feature/debug_tracecall-debug
…feature/debug_tracecall-debug
…feature/debug_tracecall-debug # Conflicts: # go.mod # proto/ethermint/evm/v1/evm.proto # tests/integration_tests/expected_constants.py # x/evm/types/evm.pb.go # x/evm/types/query.pb.go
…g response data from EVM
…feature/debug_tracecall-debug # Conflicts: # proto/ethermint/evm/v1/trace_config.proto # rpc/backend/backend.go # rpc/backend/tracing_test.go # tests/integration_tests/test_tracers.py # x/evm/keeper/grpc_query.go
…feature/debug_tracecall-debug # Conflicts: # x/evm/keeper/grpc_query.go # x/evm/keeper/state_transition.go
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
x/evm/keeper/grpc_query.go
Outdated
|
|
||
| tCtx := &tracers.Context{ | ||
| BlockHash: txConfig.BlockHash, | ||
| TxIndex: int(txConfig.TxIndex), |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
| return 0, errorsmod.Wrapf(errortypes.ErrInvalidHeight, "uint value %v cannot exceed %v", value, int(math.MaxInt64)) | ||
| } | ||
|
|
||
| return int(value), nil |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
yihuang
reviewed
Jan 4, 2024
mmsqe
reviewed
Jan 4, 2024
yihuang
approved these changes
Jan 4, 2024
|
@XinyuCRO can you check the "allow maintainers to edit" so we can directly fix some small issues. |
mmsqe
reviewed
Jan 4, 2024
yihuang
reviewed
Jan 4, 2024
…thermint into feature/debug_tracecall-debug # Conflicts: # tests/integration_tests/test_tracers.py
Co-authored-by: mmsqe <[email protected]> Signed-off-by: Xinyu <[email protected]>
Co-authored-by: mmsqe <[email protected]> Signed-off-by: Xinyu <[email protected]>
Co-authored-by: mmsqe <[email protected]> Signed-off-by: Xinyu <[email protected]>
Co-authored-by: mmsqe <[email protected]> Signed-off-by: Xinyu <[email protected]>
…thermint into feature/debug_tracecall-debug
yihuang
approved these changes
Jan 4, 2024
|
I create another PR #390 to resolve this commit sign issue, this one can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the debug_traceCall RPC method
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)