Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: rocksdb 8.0 is not used #940

Merged
merged 13 commits into from
Jul 24, 2023
Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Mar 22, 2023

Solution:

  • fix build issue in grocksdb
  • update dependencies
  • enable OptimizeFiltersForMemory

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner March 22, 2023 07:10
@yihuang yihuang requested review from JayT106 and devashishdxt and removed request for a team March 22, 2023 07:10
@yihuang yihuang marked this pull request as draft March 22, 2023 07:11
go.mod Outdated Show resolved Hide resolved
@JayT106
Copy link
Collaborator

JayT106 commented Mar 22, 2023

LGTM, is any feature Cronos need from Rocksdb v8 or just for following up on the latest Rocksdb release?

@yihuang
Copy link
Collaborator Author

yihuang commented Mar 24, 2023

LGTM, is any feature Cronos need from Rocksdb v8 or just for following up on the latest Rocksdb release?

just following up, not sure if the new option SetOptimizeFiltersForMemory has any signifiant impact in practice.

yihuang and others added 2 commits July 17, 2023 15:00
Solution:
- fix build issue in grocksdb
- update dependencies
- enable OptimizeFiltersForMemory
@yihuang yihuang requested a review from mmsqe July 17, 2023 07:08
@yihuang yihuang marked this pull request as ready for review July 17, 2023 07:08
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #940 (5cab48c) into main (9b2529f) will increase coverage by 25.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #940       +/-   ##
===========================================
+ Coverage   21.49%   46.70%   +25.20%     
===========================================
  Files          47       81       +34     
  Lines        2996     7235     +4239     
===========================================
+ Hits          644     3379     +2735     
- Misses       2289     3497     +1208     
- Partials       63      359      +296     
Impacted Files Coverage Δ
versiondb/tsrocksdb/opts.go 90.16% <100.00%> (ø)

... and 49 files with indirect coverage changes

@yihuang yihuang enabled auto-merge July 24, 2023 04:16
@yihuang yihuang added this pull request to the merge queue Jul 24, 2023
Merged via the queue into crypto-org-chain:main with commit ed242b2 Jul 24, 2023
32 checks passed
@yihuang yihuang deleted the rocksdb8 branch July 25, 2023 02:11
yihuang added a commit that referenced this pull request Jul 26, 2023
* Problem: rocksdb 8.0 is not used

Solution:
- fix build issue in grocksdb
- update dependencies
- enable OptimizeFiltersForMemory

* fix resolve

* rocksdb 8.1.1

* fix resolve

* changelog

* install golangci-lint separately

* fix workflow

* fix deps

* fix unittest workflow

* fix workflow

* fix unittest workflow

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: mmsqe <[email protected]>
yihuang added a commit that referenced this pull request Jul 26, 2023
* Problem: rocksdb 8.0 is not used

Solution:
- fix build issue in grocksdb
- update dependencies
- enable OptimizeFiltersForMemory

* fix resolve

* rocksdb 8.1.1

* fix resolve

* changelog

* install golangci-lint separately

* fix workflow

* fix deps

* fix unittest workflow

* fix workflow

* fix unittest workflow

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants