Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: No record for ADR-009 permissioned addresses in Cronos #801

Merged
merged 15 commits into from
Jan 27, 2023

Conversation

thomas-nguy
Copy link
Collaborator

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@thomas-nguy thomas-nguy requested a review from a team as a code owner January 4, 2023 01:32
@thomas-nguy thomas-nguy requested review from yihuang, leejw51crypto, tomtau and calvinaco and removed request for a team January 4, 2023 01:32
@thomas-nguy thomas-nguy force-pushed the thomas/adr-009 branch 2 times, most recently from fc3edf3 to f165cae Compare January 4, 2023 01:35
docs/architecture/adr-009.md Outdated Show resolved Hide resolved
docs/architecture/adr-009.md Outdated Show resolved Hide resolved
docs/architecture/adr-009.md Show resolved Hide resolved
Copy link
Contributor

@adu-crypto adu-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we could monitor those metrics on-chain and ask for execution of specific message automatically given the x/group module.
the option 1 seems simple and flexible because we could do most of the monitoring work off-chain and only add the permissions map to the cronos store, while we need to specify the policy if we choose option 2.

docs/architecture/adr-009.md Outdated Show resolved Hide resolved
@thomas-nguy
Copy link
Collaborator Author

I havent found anything related to "restrict message to a certain group" in x/module. Maybe in x/authz? but it seems more related to module's authorization.

@thomas-nguy
Copy link
Collaborator Author

@tomtau @calvinaco @yihuang

I have updated the ADR with final decision. Let me know if it is okay to merge

docs/architecture/adr-009.md Outdated Show resolved Hide resolved
docs/architecture/adr-009.md Outdated Show resolved Hide resolved
@thomas-nguy thomas-nguy enabled auto-merge (squash) January 26, 2023 08:34
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #801 (a864192) into main (c6dd8f9) will increase coverage by 0.36%.
The diff coverage is n/a.

❗ Current head a864192 differs from pull request most recent head f4c23ef. Consider uploading reports for the commit f4c23ef to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #801      +/-   ##
==========================================
+ Coverage   33.89%   34.26%   +0.36%     
==========================================
  Files          30       30              
  Lines        1599     1582      -17     
==========================================
  Hits          542      542              
+ Misses       1000      983      -17     
  Partials       57       57              
Impacted Files Coverage Δ
app/upgrades.go 0.00% <0.00%> (ø)

@thomas-nguy thomas-nguy merged commit 923f032 into crypto-org-chain:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants