Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: no MaxTx set from config for mempool #1500

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Problem: no MaxTx set from config for mempool #1500

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d95707
Problem: no MaxTx set in mempool
mmsqe Jul 2, 2024
78b169d
default max-txs
yihuang Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
* [#1490](https://github.com/crypto-org-chain/cronos/pull/1490) Update cometbft to v0.38.8.
* (versiondb) [#1491](https://github.com/crypto-org-chain/cronos/pull/1491) Free slice data in HasAtVersion.
* (versiondb) [#1498](https://github.com/crypto-org-chain/cronos/pull/1498) Reduce scope of copying slice data in iterator.
* [#1500](https://github.com/crypto-org-chain/cronos/pull/1500) Set mempool MaxTx from config.


yihuang marked this conversation as resolved.
Show resolved Hide resolved
*Jun 18, 2024*
mmsqe marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
1 change: 1 addition & 0 deletions app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ func New(
mempool := mempool.NewPriorityMempool(mempool.PriorityNonceMempoolConfig[int64]{
TxPriority: mempool.NewDefaultTxPriority(),
SignerExtractor: evmapp.NewEthSignerExtractionAdapter(mempool.NewDefaultSignerExtractionAdapter()),
MaxTx: cast.ToInt(appOpts.Get(server.FlagMempoolMaxTxs)),
yihuang marked this conversation as resolved.
Show resolved Hide resolved
yihuang marked this conversation as resolved.
Show resolved Hide resolved
})
handler := baseapp.NewDefaultProposalHandler(mempool, app)

Expand Down
3 changes: 3 additions & 0 deletions integration_tests/configs/default.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
'block-range-cap': 10000,
'logs-cap': 10000,
},
mempool: {
'max-txs': 1000,
},
evm: {
'block-executor': 'block-stm',
},
Expand Down
Loading