abci: Add relaxed local client synchronization models (backport #1141) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* proxy: Remove "unsynchronized" local client creator Signed-off-by: Thane Thomson <[email protected]> * proxy: Expand client creator interface Expand the `ClientCreator` interface to allow the caller to explicitly specify the "connection" whose client they are creating. This potentially gives greater control over the concurrency model employed in each type of connection. Signed-off-by: Thane Thomson <[email protected]> * abci/client: Clarify NewLocalClient description Signed-off-by: Thane Thomson <[email protected]> * proxy: Add connection-synchronized local client creator Analogous to the old "unsynchronized" local client creator. Signed-off-by: Thane Thomson <[email protected]> * abci/client: Add unsynchronized local client Signed-off-by: Thane Thomson <[email protected]> * proxy: Add consensus-synchronized local client creator Signed-off-by: Thane Thomson <[email protected]> * proxy: Fix mock configuration in test Signed-off-by: Thane Thomson <[email protected]> * Add changelog entries Signed-off-by: Thane Thomson <[email protected]> * Remove changelog entry - no longer necessary Signed-off-by: Thane Thomson <[email protected]> * proxy: Add unsynchronized local client creator Signed-off-by: Thane Thomson <[email protected]> * changelog: Add entry for unsync local client creator Signed-off-by: Thane Thomson <[email protected]> * Update 1141-abci-unsync-proxy.md Co-authored-by: Adi Seredinschi <[email protected]> --------- Signed-off-by: Thane Thomson <[email protected]> Co-authored-by: Adi Seredinschi <[email protected]>
|
sdk 0.50 only works with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proxy: Remove "unsynchronized" local client creator
proxy: Expand client creator interface
Expand the
ClientCreatorinterface to allow the caller to explicitly specify the "connection" whose client they are creating. This potentially gives greater control over the concurrency model employed in each type of connection.abci/client: Clarify NewLocalClient description
proxy: Add connection-synchronized local client creator
Analogous to the old "unsynchronized" local client creator.
abci/client: Add unsynchronized local client
proxy: Add consensus-synchronized local client creator
proxy: Fix mock configuration in test
Add changelog entries
Remove changelog entry - no longer necessary
proxy: Add unsynchronized local client creator
changelog: Add entry for unsync local client creator
Update 1141-abci-unsync-proxy.md
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments