Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore(matchExpressions): rename target.isAgent match expression to target.agent to fit current nomenclature" #631

Closed
wants to merge 1 commit into from
Closed

Revert "chore(matchExpressions): rename target.isAgent match expression to target.agent to fit current nomenclature" #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions schema/schema.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ type RuntimeMetrics {

type Target {
activeRecordings(filter: ActiveRecordingsFilterInput): ActiveRecordings
agent: Boolean!
alias: String!
annotations: Annotations!
archivedRecordings(filter: ArchivedRecordingsFilterInput): ArchivedRecordings
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/io/cryostat/expressions/MatchExpressionEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ public static class ScriptCreation extends Event {}
* expression-relevant fields exposed, connection URI exposed as a String, etc.
*/
private static record SimplifiedTarget(
boolean agent,
boolean isAgent,
String connectUrl,
String alias,
@Nullable String jvmId,
Expand All @@ -242,7 +242,7 @@ private static record SimplifiedTarget(

static SimplifiedTarget from(Target target) {
return new SimplifiedTarget(
target.agent(),
target.isAgent(),
target.connectUrl.toString(),
target.alias,
target.jvmId,
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/cryostat/targets/Target.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public class Target extends PanacheEntity {
public DiscoveryNode discoveryNode;

@JsonProperty(access = JsonProperty.Access.READ_ONLY)
public boolean agent() {
public boolean isAgent() {
return AgentConnection.isAgentConnection(connectUrl);
}

Expand Down
Loading