test(itest): overwrite the IllegalArgumentException http code #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkonno
changed the title
src/main/java/io/cryostat/util/IllegalArgumentExceptionMapper.java
Outdated
Show resolved
Hide resolved
lkonno
force-pushed
the
invalidmime_httpcode
branch
from
d172ea1
to
fec7b3e
Compare
andrewazores
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainRelated to: #147
Description of the change:
Overwritting the IllegalArgumentException http code to 400 Bad Request
Motivation for the change:
The RulesPostJsonIT.testAddRuleThrowsWhenRuleNameAlreadyExists is expecting 500 error code, but it seems wrong (in my opinion, this is a bug from quarkus or rest). A request with invalid header should be returning a client code (4xx).
How to manually test:
mvn clean verify