Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(smoketest): use updated cryostat3 container image tag #146

Merged
merged 2 commits into from
Nov 8, 2023
Merged

test(smoketest): use updated cryostat3 container image tag #146

merged 2 commits into from
Nov 8, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Related to #144 #145

@andrewazores andrewazores added test chore Refactor, rename, cleanup, etc. safe-to-test labels Nov 8, 2023
@aali309
Copy link
Contributor

aali309 commented Nov 8, 2023

@andrewazores, this error is expected for java v17? I have the same issue with my PR

image

@andrewazores
Copy link
Member Author

See #147

aali309
aali309 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewazores andrewazores merged commit edb04d9 into cryostatio:main Nov 8, 2023
8 of 9 checks passed
@andrewazores andrewazores deleted the smoketest-ci-image branch November 8, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aali309 aali309 aali309 approved these changes

@mwangggg mwangggg Awaiting requested review from mwangggg

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc. safe-to-test test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @aali309